-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: image and file cdn url generator adapter implementation #38685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Nov 2, 2023
pieh
reviewed
Nov 3, 2023
packages/gatsby-plugin-utils/src/polyfill-remote-file/utils/url-generator.ts
Outdated
Show resolved
Hide resolved
pieh
added
topic: media
Related to gatsby-plugin-image, or general image/media processing topics
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Nov 3, 2023
pieh
force-pushed
the
alternate-image-url
branch
from
November 13, 2023 10:37
eb242c6
to
5b81ecd
Compare
…38715) * feat: move custom image cdn url generator implementation to adapter * provide public types for custom image cdn url generator function signature and individual arguments
kathmbeck
changed the title
feat(gatsby-plugin-utils): alternate image url construction
feat: image cdn url generator adapter implementation
Nov 30, 2023
pieh
reviewed
Nov 30, 2023
pieh
reviewed
Nov 30, 2023
pieh
reviewed
Nov 30, 2023
This was referenced May 7, 2024
This was referenced May 9, 2024
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR now includes adapter support for Image CDN
https://linear.app/netlify/issue/FRA-14/implement-image-cdn .
Documentation
Tests
Unit tests and E2E tests
Related Issues
https://linear.app/netlify/issue/FRA-14/implement-image-cdn